Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-05-02 Thread Alexander Duyck
On Mon, May 2, 2016 at 4:18 PM, Tom Herbert wrote: > On Mon, May 2, 2016 at 3:54 PM, Alexander Duyck > wrote: >> On Mon, May 2, 2016 at 2:21 PM, Jarno Rajahalme wrote: >>> On Apr 29, 2016, at 8:46 PM, Alexander Duyck wrote: On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-05-02 Thread Tom Herbert
On Mon, May 2, 2016 at 3:54 PM, Alexander Duyck wrote: > On Mon, May 2, 2016 at 2:21 PM, Jarno Rajahalme wrote: >> >>> On Apr 29, 2016, at 8:46 PM, Alexander Duyck >>> wrote: >>> >>> On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: UDP tunnel segmentation code relies on the inner o

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-05-02 Thread Alexander Duyck
On Mon, May 2, 2016 at 2:21 PM, Jarno Rajahalme wrote: > >> On Apr 29, 2016, at 8:46 PM, Alexander Duyck >> wrote: >> >> On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: >>> UDP tunnel segmentation code relies on the inner offsets being set for >>> an UDP tunnel GSO packet. The inner *_

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-05-02 Thread Jarno Rajahalme
> On Apr 29, 2016, at 8:46 PM, Alexander Duyck > wrote: > > On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: >> UDP tunnel segmentation code relies on the inner offsets being set for >> an UDP tunnel GSO packet. The inner *_complete() functions will set >> the inner offsets only if the

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-05-02 Thread Jarno Rajahalme
> On Apr 29, 2016, at 6:42 PM, Tom Herbert wrote: > > On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: >> UDP tunnel segmentation code relies on the inner offsets being set for >> an UDP tunnel GSO packet. The inner *_complete() functions will set >> the inner offsets only if the encaps

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-04-29 Thread Alexander Duyck
On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: > UDP tunnel segmentation code relies on the inner offsets being set for > an UDP tunnel GSO packet. The inner *_complete() functions will set > the inner offsets only if the encapsulation is set before calling > them, but udp_gro_complete()

Re: [PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-04-29 Thread Tom Herbert
On Fri, Apr 29, 2016 at 3:28 PM, Jarno Rajahalme wrote: > UDP tunnel segmentation code relies on the inner offsets being set for > an UDP tunnel GSO packet. The inner *_complete() functions will set > the inner offsets only if the encapsulation is set before calling > them, but udp_gro_complete()

[PATCH net 2/3] udp_offload: Set encapsulation before inner completes.

2016-04-29 Thread Jarno Rajahalme
UDP tunnel segmentation code relies on the inner offsets being set for an UDP tunnel GSO packet. The inner *_complete() functions will set the inner offsets only if the encapsulation is set before calling them, but udp_gro_complete() set it only after the inner *_complete() functions were done. A