Re: [PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend

2021-03-10 Thread Florian Fainelli
On 3/10/21 2:56 PM, Florian Fainelli wrote: > On 3/10/21 1:43 PM, Heiner Kallweit wrote: >> On 10.03.2021 22:15, Florian Fainelli wrote: >>> On 3/10/21 1:07 PM, Heiner Kallweit wrote: On 10.03.2021 21:41, Florian Fainelli wrote: > B50212E PHYs have been observed to get into an incorrect st

Re: [PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend

2021-03-10 Thread Florian Fainelli
On 3/10/21 1:43 PM, Heiner Kallweit wrote: > On 10.03.2021 22:15, Florian Fainelli wrote: >> On 3/10/21 1:07 PM, Heiner Kallweit wrote: >>> On 10.03.2021 21:41, Florian Fainelli wrote: B50212E PHYs have been observed to get into an incorrect state with the visible effect of having both ac

Re: [PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend

2021-03-10 Thread Heiner Kallweit
On 10.03.2021 22:15, Florian Fainelli wrote: > On 3/10/21 1:07 PM, Heiner Kallweit wrote: >> On 10.03.2021 21:41, Florian Fainelli wrote: >>> B50212E PHYs have been observed to get into an incorrect state with the >>> visible effect of having both activity and link LEDs flashing >>> alternatively i

Re: [PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend

2021-03-10 Thread Florian Fainelli
On 3/10/21 1:07 PM, Heiner Kallweit wrote: > On 10.03.2021 21:41, Florian Fainelli wrote: >> B50212E PHYs have been observed to get into an incorrect state with the >> visible effect of having both activity and link LEDs flashing >> alternatively instead of being turned off as intended when >> genp

Re: [PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend

2021-03-10 Thread Heiner Kallweit
On 10.03.2021 21:41, Florian Fainelli wrote: > B50212E PHYs have been observed to get into an incorrect state with the > visible effect of having both activity and link LEDs flashing > alternatively instead of being turned off as intended when > genphy_suspend() was issued. The BCM54810 is a simila

[PATCH net 2/3] net: phy: broadcom: Only set BMCR.PDOWN to suspend

2021-03-10 Thread Florian Fainelli
B50212E PHYs have been observed to get into an incorrect state with the visible effect of having both activity and link LEDs flashing alternatively instead of being turned off as intended when genphy_suspend() was issued. The BCM54810 is a similar design and equally suffers from that issue. The da