Re: [PATCH net 2/2] tipc: fix possible crash in __tipc_nl_net_set()

2018-04-17 Thread Ying Xue
On 04/16/2018 11:29 PM, Eric Dumazet wrote: > syzbot reported a crash in __tipc_nl_net_set() caused by NULL dereference. > > We need to check that both TIPC_NLA_NET_NODEID and TIPC_NLA_NET_NODEID_W1 > are present. > > We also need to make sure userland provided u64 attributes. > > Fixes: d50ccc2

[PATCH net 2/2] tipc: fix possible crash in __tipc_nl_net_set()

2018-04-16 Thread Eric Dumazet
syzbot reported a crash in __tipc_nl_net_set() caused by NULL dereference. We need to check that both TIPC_NLA_NET_NODEID and TIPC_NLA_NET_NODEID_W1 are present. We also need to make sure userland provided u64 attributes. Fixes: d50ccc2d3909 ("tipc: add 128-bit node identifier") Signed-off-by: E