Re: [PATCH net 2/2] tcp: tcp_v4_err() should be more careful

2019-02-15 Thread Soheil Hassas Yeganeh
On Fri, Feb 15, 2019 at 9:21 PM Neal Cardwell wrote: > > On Fri, Feb 15, 2019 at 4:36 PM Eric Dumazet wrote: > > > > ICMP handlers are not very often stressed, we should > > make them more resilient to bugs that might surface in > > the future. > > > > If there is no packet in retransmit queue, w

Re: [PATCH net 2/2] tcp: tcp_v4_err() should be more careful

2019-02-15 Thread Neal Cardwell
On Fri, Feb 15, 2019 at 4:36 PM Eric Dumazet wrote: > > ICMP handlers are not very often stressed, we should > make them more resilient to bugs that might surface in > the future. > > If there is no packet in retransmit queue, we should > avoid a NULL deref. > > Signed-off-by: Eric Dumazet > Repo

[PATCH net 2/2] tcp: tcp_v4_err() should be more careful

2019-02-15 Thread Eric Dumazet
ICMP handlers are not very often stressed, we should make them more resilient to bugs that might surface in the future. If there is no packet in retransmit queue, we should avoid a NULL deref. Signed-off-by: Eric Dumazet Reported-by: soukjin bae --- net/ipv4/tcp_ipv4.c | 5 - 1 file change