Re: [PATCH net 2/2] net: Call skb destructor on NAPI_GRO_FREE_STOLEN_HEAD

2020-11-25 Thread Saeed Mahameed
On Wed, 2020-11-18 at 21:21 +0100, Eric Dumazet wrote: > On Wed, Nov 18, 2020 at 9:14 PM Jakub Kicinski > wrote: > > On Wed, 18 Nov 2020 21:02:29 +0100 Eric Dumazet wrote: > > > On Wed, Nov 18, 2020 at 8:22 PM Jakub Kicinski > > > wrote: > > > > On Tue, 17 Nov 2020 12:33:55 -0800 Saeed Mahameed w

Re: [PATCH net 2/2] net: Call skb destructor on NAPI_GRO_FREE_STOLEN_HEAD

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 21:02:29 +0100 Eric Dumazet wrote: > On Wed, Nov 18, 2020 at 8:22 PM Jakub Kicinski wrote: > > > > On Tue, 17 Nov 2020 12:33:55 -0800 Saeed Mahameed wrote: > > > From: Maxim Mikityanskiy > > > > > > All GRO flows except one call skb->destructor, however, GRO_MERGED_FREE > >

Re: [PATCH net 2/2] net: Call skb destructor on NAPI_GRO_FREE_STOLEN_HEAD

2020-11-18 Thread Jakub Kicinski
On Tue, 17 Nov 2020 12:33:55 -0800 Saeed Mahameed wrote: > From: Maxim Mikityanskiy > > All GRO flows except one call skb->destructor, however, GRO_MERGED_FREE > doesn't do it in case of NAPI_GRO_FREE_STOLEN_HEAD. For better > consistency and to add resiliency against the drivers that may pass SK

[PATCH net 2/2] net: Call skb destructor on NAPI_GRO_FREE_STOLEN_HEAD

2020-11-17 Thread Saeed Mahameed
From: Maxim Mikityanskiy All GRO flows except one call skb->destructor, however, GRO_MERGED_FREE doesn't do it in case of NAPI_GRO_FREE_STOLEN_HEAD. For better consistency and to add resiliency against the drivers that may pass SKBs with a destructor, this patch changes napi_skb_free_stolen_head