Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Andrew Lunn
> Only case I can see the need for a make/model string is if there's a > need to add model-specific properties since you'd need a compatible > then (or make those properties shared between all phy bindings). Documentation/devicetree/bindings/net/micrel-ksz90x1.txt It adds optional properties to t

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Olof Johansson
On Wed, Jan 27, 2016 at 9:11 AM, Andrew Lunn wrote: > On Wed, Jan 27, 2016 at 08:41:56AM -0800, Olof Johansson wrote: >> On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: >> > PHY devices may only list clause 22, 45, and their PHY identifier >> > values as compatible values. No other compatible

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Andrew Lunn
On Wed, Jan 27, 2016 at 08:41:56AM -0800, Olof Johansson wrote: > On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: > > PHY devices may only list clause 22, 45, and their PHY identifier > > values as compatible values. No other compatible strings are allowed. > > Make this clear in the documenta

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Olof Johansson
On Tue, Jan 26, 2016 at 4:11 PM, Andrew Lunn wrote: > PHY devices may only list clause 22, 45, and their PHY identifier > values as compatible values. No other compatible strings are allowed. > Make this clear in the documentation, and remove examples where > make/model compatible strings are list

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-27 Thread Florian Fainelli
On January 26, 2016 5:57:55 PM PST, Andrew Lunn wrote: >> Well, we do now, since that is one of the results used by >> of_mdiobus_child_is_phy(), > >It uses it, but do not rely on it, since for backwards compatibility, >we cannot assume it is there. > >You can never change an optional parameter to

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-26 Thread Andrew Lunn
> Well, we do now, since that is one of the results used by > of_mdiobus_child_is_phy(), It uses it, but do not rely on it, since for backwards compatibility, we cannot assume it is there. You can never change an optional parameter to a mandatory parameter in DT. To do so breaks backwards compati

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-26 Thread Florian Fainelli
On 26/01/16 17:06, Andrew Lunn wrote: > On Tue, Jan 26, 2016 at 04:33:11PM -0800, Florian Fainelli wrote: >> On 26/01/16 16:11, Andrew Lunn wrote: >>> PHY devices may only list clause 22, 45, and their PHY identifier >>> values as compatible values. No other compatible strings are allowed. >>> Make

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-26 Thread Andrew Lunn
On Tue, Jan 26, 2016 at 04:33:11PM -0800, Florian Fainelli wrote: > On 26/01/16 16:11, Andrew Lunn wrote: > > PHY devices may only list clause 22, 45, and their PHY identifier > > values as compatible values. No other compatible strings are allowed. > > Make this clear in the documentation, and rem

Re: [PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-26 Thread Florian Fainelli
On 26/01/16 16:11, Andrew Lunn wrote: > PHY devices may only list clause 22, 45, and their PHY identifier > values as compatible values. No other compatible strings are allowed. > Make this clear in the documentation, and remove examples where > make/model compatible strings are listed. Humm, shou

[PATCH net 2/2] DT: phy.txt: Clarify expected compatible values

2016-01-26 Thread Andrew Lunn
PHY devices may only list clause 22, 45, and their PHY identifier values as compatible values. No other compatible strings are allowed. Make this clear in the documentation, and remove examples where make/model compatible strings are listed. Signed-off-by: Andrew Lunn --- Documentation/devicetre