RE: [EXT] Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-24 Thread Andy Duan
From: Fuzzey, Martin Sent: Saturday, May 23, 2020 5:56 PM > Hi Andy, > > > Fixes: da722186f654(net: fec: set GPR bit on suspend by DT > > configuration) > > Just a nitpick maybe but I don't really think this need as Fixes: tag. > That commit didn't actually *break* anything AFAIK. > It added Wo

Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-23 Thread Fuzzey, Martin
Hi Andy, > Fixes: da722186f654(net: fec: set GPR bit on suspend by DT configuration) Just a nitpick maybe but I don't really think this need as Fixes: tag. That commit didn't actually *break* anything AFAIK. It added WoL support for *some* SoCs that didn't have any in mainline and didn't hurt the

RE: [EXT] Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-20 Thread Andy Duan
From: Jakub Kicinski Sent: Thursday, May 21, 2020 12:54 AM > On Wed, 20 May 2020 16:31:53 +0800 fugang.d...@nxp.com wrote: > > From: Fugang Duan > > > > The commit da722186f654(net: fec: set GPR bit on suspend by DT > > configuration) set the GPR reigster offset and bit in driver for wake > > on

Re: [PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-20 Thread Jakub Kicinski
On Wed, 20 May 2020 16:31:53 +0800 fugang.d...@nxp.com wrote: > From: Fugang Duan > > The commit da722186f654(net: fec: set GPR bit on suspend by DT > configuration) set the GPR reigster offset and bit in driver for > wake on lan feature. > > But it introduces two issues here: > - one SOC has tw

[PATCH net 1/4] net: ethernet: fec: move GPR register offset and bit into DT

2020-05-20 Thread fugang . duan
From: Fugang Duan The commit da722186f654(net: fec: set GPR bit on suspend by DT configuration) set the GPR reigster offset and bit in driver for wake on lan feature. But it introduces two issues here: - one SOC has two instances, they have different bit - different SOCs may have different offse