Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-23 Thread Alexander Duyck
On Mon, May 22, 2017 at 4:59 PM, David Miller wrote: > From: Vladislav Yasevich > Date: Thu, 18 May 2017 09:31:03 -0400 > >> It appears that since commit 8cb65d000, Q-in-Q vlans have been >> broken. The series that commit is part of enabled TSO and checksum >> offloading on Q-in-Q vlans. Howeve

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-23 Thread Vlad Yasevich
On 05/22/2017 07:59 PM, David Miller wrote: > From: Vladislav Yasevich > Date: Thu, 18 May 2017 09:31:03 -0400 > >> It appears that since commit 8cb65d000, Q-in-Q vlans have been >> broken. The series that commit is part of enabled TSO and checksum >> offloading on Q-in-Q vlans. However, most H

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-22 Thread David Miller
From: Vladislav Yasevich Date: Thu, 18 May 2017 09:31:03 -0400 > It appears that since commit 8cb65d000, Q-in-Q vlans have been > broken. The series that commit is part of enabled TSO and checksum > offloading on Q-in-Q vlans. However, most HW we support can't handle > it. To work around the i

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Toshiaki Makita
On 17/05/19 (金) 18:53, Vlad Yasevich wrote: On 05/19/2017 04:16 AM, Toshiaki Makita wrote: On 2017/05/19 16:09, Vlad Yasevich wrote: On 05/18/2017 10:13 PM, Toshiaki Makita wrote: On 2017/05/18 22:31, Vladislav Yasevich wrote: It appears that since commit 8cb65d000, Q-in-Q vlans have been bro

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Vlad Yasevich
On 05/19/2017 04:16 AM, Toshiaki Makita wrote: > On 2017/05/19 16:09, Vlad Yasevich wrote: >> On 05/18/2017 10:13 PM, Toshiaki Makita wrote: >>> On 2017/05/18 22:31, Vladislav Yasevich wrote: It appears that since commit 8cb65d000, Q-in-Q vlans have been broken. The series that commit is

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Toshiaki Makita
On 2017/05/19 16:09, Vlad Yasevich wrote: > On 05/18/2017 10:13 PM, Toshiaki Makita wrote: >> On 2017/05/18 22:31, Vladislav Yasevich wrote: >>> It appears that since commit 8cb65d000, Q-in-Q vlans have been >>> broken. The series that commit is part of enabled TSO and checksum >>> offloading on Q

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-19 Thread Vlad Yasevich
On 05/18/2017 10:13 PM, Toshiaki Makita wrote: > On 2017/05/18 22:31, Vladislav Yasevich wrote: >> It appears that since commit 8cb65d000, Q-in-Q vlans have been >> broken. The series that commit is part of enabled TSO and checksum >> offloading on Q-in-Q vlans. However, most HW we support can't

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-18 Thread Toshiaki Makita
On 2017/05/18 22:31, Vladislav Yasevich wrote: > It appears that since commit 8cb65d000, Q-in-Q vlans have been > broken. The series that commit is part of enabled TSO and checksum > offloading on Q-in-Q vlans. However, most HW we support can't handle > it. To work around the issue, the above co

Re: [PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-18 Thread Toshiaki Makita
On 2017/05/18 22:31, Vladislav Yasevich wrote: > It appears that since commit 8cb65d000, Q-in-Q vlans have been > broken. The series that commit is part of enabled TSO and checksum > offloading on Q-in-Q vlans. However, most HW we support can't handle > it. To work around the issue, the above co

[PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-18 Thread Vladislav Yasevich
It appears that since commit 8cb65d000, Q-in-Q vlans have been broken. The series that commit is part of enabled TSO and checksum offloading on Q-in-Q vlans. However, most HW we support can't handle it. To work around the issue, the above commit added a function that turns off offloads on Q-in-Q