Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread Alexei Starovoitov
On 7/17/15 2:05 PM, John Fastabend wrote: On 15-07-17 01:38 PM, Daniel Borkmann wrote: >The following test case causes a NULL pointer dereference in cls_bpf: > > FOO="1,6 0 0 4294967295," > tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok > tc filter replace dev foo

Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread Daniel Borkmann
On 07/17/2015 11:05 PM, John Fastabend wrote: ... Thanks Daniel. Apparently I got this right in cls_basic but botched it here and in cls_flow. Yep, it's correct there. :) Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@v

Re: [PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread John Fastabend
On 15-07-17 01:38 PM, Daniel Borkmann wrote: > The following test case causes a NULL pointer dereference in cls_bpf: > > FOO="1,6 0 0 4294967295," > tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok > tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ >

[PATCH net 1/3] sched: cls_bpf: fix panic on filter replace

2015-07-17 Thread Daniel Borkmann
The following test case causes a NULL pointer dereference in cls_bpf: FOO="1,6 0 0 4294967295," tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 action ok tc filter replace dev foo parent 1: pref 49152 handle 0x1 \ bpf bytecode "$FOO" flowid 1:1 action drop The pro