Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-17 Thread Jerome Brunet
On Thu, 2016-11-17 at 23:30 +0530, Anand Moon wrote: > Hi Jerone, > > > > How about adding callback functionality for .soft_reset to handle > > > BMCR > > > where we update the Auto-Negotiation for the phy, > > > as per the datasheet of the rtl8211f. I think BMCR is already pretty well handled by

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-17 Thread Anand Moon
Hi Jerone, On 17 November 2016 at 15:50, Jerome Brunet wrote: > On Wed, 2016-11-16 at 22:36 +0530, Anand Moon wrote: >> Hi Jerome. >> >> On 15 November 2016 at 19:59, Jerome Brunet >> wrote: >> > >> > On some platforms, energy efficient ethernet with rtl8211 devices >> > is >> > causing issue,

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-17 Thread Jerome Brunet
On Wed, 2016-11-16 at 22:36 +0530, Anand Moon wrote: >  Hi Jerome. > > On 15 November 2016 at 19:59, Jerome Brunet > wrote: > > > > On some platforms, energy efficient ethernet with rtl8211 devices > > is > > causing issue, like throughput drop or broken link. > > > > This was reported on the O

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Anand Moon
Hi Jerome. On 15 November 2016 at 19:59, Jerome Brunet wrote: > On some platforms, energy efficient ethernet with rtl8211 devices is > causing issue, like throughput drop or broken link. > > This was reported on the OdroidC2 (DWMAC + RTL8211F). While the issue root > cause is not fully understoo

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Florian Fainelli
On 11/16/2016 07:38 AM, Jerome Brunet wrote: > On Wed, 2016-11-16 at 16:06 +0100, Andrew Lunn wrote: >> On Wed, Nov 16, 2016 at 03:51:30PM +0100, Jerome Brunet wrote: >>> >>> On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote: > > > There two kind of PHYs supporting eee, the one

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Jerome Brunet
On Wed, 2016-11-16 at 16:06 +0100, Andrew Lunn wrote: > On Wed, Nov 16, 2016 at 03:51:30PM +0100, Jerome Brunet wrote: > > > > On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote: > > > > > > > > > > > > > > > There two kind of PHYs supporting eee, the one advertising eee > > > > by > > > > de

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Andrew Lunn
On Wed, Nov 16, 2016 at 03:51:30PM +0100, Jerome Brunet wrote: > On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote: > > > > > > There two kind of PHYs supporting eee, the one advertising eee by > > > default (like realtek) and the one not advertising it (like > > > micrel). > > This is just th

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Jerome Brunet
On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote: > > > > There two kind of PHYs supporting eee, the one advertising eee by > > default (like realtek) and the one not advertising it (like > > micrel). This is just the default register value. > > I don't know too much about EEE. So maybe a d

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Andrew Lunn
> There two kind of PHYs supporting eee, the one advertising eee by > default (like realtek) and the one not advertising it (like micrel). I don't know too much about EEE. So maybe a dumb question. Does the MAC need to be involved? Or is it just the PHY? If the MAC needs to be involved, the PHY s

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Jerome Brunet
On Tue, 2016-11-15 at 09:03 -0800, Florian Fainelli wrote: > On 11/15/2016 08:30 AM, Andrew Lunn wrote: > > > > On Tue, Nov 15, 2016 at 03:29:12PM +0100, Jerome Brunet wrote: > > > > > > On some platforms, energy efficient ethernet with rtl8211 devices > > > is > > > causing issue, like throughpu

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-15 Thread Florian Fainelli
On 11/15/2016 08:30 AM, Andrew Lunn wrote: > On Tue, Nov 15, 2016 at 03:29:12PM +0100, Jerome Brunet wrote: >> On some platforms, energy efficient ethernet with rtl8211 devices is >> causing issue, like throughput drop or broken link. >> >> This was reported on the OdroidC2 (DWMAC + RTL8211F). Whil

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-15 Thread Andrew Lunn
On Tue, Nov 15, 2016 at 03:29:12PM +0100, Jerome Brunet wrote: > On some platforms, energy efficient ethernet with rtl8211 devices is > causing issue, like throughput drop or broken link. > > This was reported on the OdroidC2 (DWMAC + RTL8211F). While the issue root > cause is not fully understood

[PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-15 Thread Jerome Brunet
On some platforms, energy efficient ethernet with rtl8211 devices is causing issue, like throughput drop or broken link. This was reported on the OdroidC2 (DWMAC + RTL8211F). While the issue root cause is not fully understood yet, disabling EEE advertisement prevent auto negotiation from enabling