Re: [PATCH net 1/3] ibmvnic: rework to ensure SCRQ entry reads are properly ordered

2021-01-24 Thread Lijun Pan
On Sat, Jan 23, 2021 at 11:10 PM Jakub Kicinski wrote: > > On Thu, 21 Jan 2021 00:17:08 -0600 Lijun Pan wrote: > > Move the dma_rmb() between pending_scrq() and ibmvnic_next_scrq() > > into the end of pending_scrq(), and explain why. > > Explain in detail why the dma_rmb() is placed at the end of

Re: [PATCH net 1/3] ibmvnic: rework to ensure SCRQ entry reads are properly ordered

2021-01-23 Thread Jakub Kicinski
On Thu, 21 Jan 2021 00:17:08 -0600 Lijun Pan wrote: > Move the dma_rmb() between pending_scrq() and ibmvnic_next_scrq() > into the end of pending_scrq(), and explain why. > Explain in detail why the dma_rmb() is placed at the end of > ibmvnic_next_scrq(). > > Fixes: b71ec9522346 ("ibmvnic: Ensure

[PATCH net 1/3] ibmvnic: rework to ensure SCRQ entry reads are properly ordered

2021-01-20 Thread Lijun Pan
Move the dma_rmb() between pending_scrq() and ibmvnic_next_scrq() into the end of pending_scrq(), and explain why. Explain in detail why the dma_rmb() is placed at the end of ibmvnic_next_scrq(). Fixes: b71ec9522346 ("ibmvnic: Ensure that SCRQ entry reads are correctly ordered") Signed-off-by: Li