Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave

2018-03-26 Thread Andy Gospodarek
On Mon, Mar 26, 2018 at 01:16:45AM +0800, Xin Long wrote: > vlan_vids_add_by_dev is called right after dev hwaddr sync, so on > the err path it should unsync dev hwaddr. Otherwise, the slave > dev's hwaddr will never be unsync when this err happens. > > Fixes: 1ff412ad7714 ("bonding: change the bo

Re: [PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave

2018-03-26 Thread Nikolay Aleksandrov
On 25/03/18 20:16, Xin Long wrote: vlan_vids_add_by_dev is called right after dev hwaddr sync, so on the err path it should unsync dev hwaddr. Otherwise, the slave dev's hwaddr will never be unsync when this err happens. Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions wit

[PATCH net 1/3] bonding: fix the err path for dev hwaddr sync in bond_enslave

2018-03-25 Thread Xin Long
vlan_vids_add_by_dev is called right after dev hwaddr sync, so on the err path it should unsync dev hwaddr. Otherwise, the slave dev's hwaddr will never be unsync when this err happens. Fixes: 1ff412ad7714 ("bonding: change the bond's vlan syncing functions with the standard ones") Signed-off-by: