Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-22 Thread Steffen Klassert
On Wed, Jun 21, 2017 at 08:38:13PM +, Yossi Kuperman wrote: > > The bug is there nonetheless, it just doesn't seem to affect anything. > I guess no one was looking inside the IP header thereafter. > > Should I use this instead: 7785bba299a8 ("esp: Add a software GRO codepath")? Yes, please

RE: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-21 Thread Yossi Kuperman
; > > Yevgeny Kliteynik ; Boris Pismenny > > ; Ilan Tayari > > Subject: Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in > > xfrm6_transport_finish > > > > On Wed, Jun 21, 2017 at 11:24:05AM +, Yossi Kuperman wrote: > > > > > > > > &g

RE: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-21 Thread Yossi Kuperman
ent: Wednesday, June 21, 2017 8:37 AM > > > To: Yossi Kuperman > > > Cc: netdev@vger.kernel.org; Herbert Xu > > > ; Yevgeny Kliteynik > > > ; Boris Pismenny ; Ilan > > > Tayari > > > Subject: Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in

Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-21 Thread Steffen Klassert
kernel.org; Herbert Xu ; > > Yevgeny Kliteynik ; Boris Pismenny > > ; Ilan Tayari > > Subject: Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in > > xfrm6_transport_finish > > > > On Mon, Jun 19, 2017 at 11:33:20AM +0300, yoss...@mellanox.com wrote: > > >

RE: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-21 Thread Yossi Kuperman
> -Original Message- > From: Steffen Klassert [mailto:steffen.klass...@secunet.com] > Sent: Wednesday, June 21, 2017 8:37 AM > To: Yossi Kuperman > Cc: netdev@vger.kernel.org; Herbert Xu ; > Yevgeny Kliteynik ; Boris Pismenny > ; Ilan Tayari > Subject: Re: [P

Re: [PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-20 Thread Steffen Klassert
On Mon, Jun 19, 2017 at 11:33:20AM +0300, yoss...@mellanox.com wrote: > From: Yossi Kuperman > > IPv6 payload length indicates the size of the payload, including any > extension headers. In xfrm6_transport_finish, ipv6_hdr(skb)->payload_len > is set to the payload size only, regardless of the pre

[PATCH net 1/2] xfrm6: Fix IPv6 payload_len in xfrm6_transport_finish

2017-06-19 Thread yossiku
From: Yossi Kuperman IPv6 payload length indicates the size of the payload, including any extension headers. In xfrm6_transport_finish, ipv6_hdr(skb)->payload_len is set to the payload size only, regardless of the presence of any extension headers. After ESP GRO transport mode decapsulation, ipv