Re: [PATCH net 1/2] sctp: fix stream update when processing dupcookie

2017-05-23 Thread Vlad Yasevich
On 05/23/2017 01:28 AM, Xin Long wrote: > Since commit 3dbcc105d556 ("sctp: alloc stream info when initializing > asoc"), stream and stream.out info are always alloced when creating > an asoc. > > So it's not correct to check !asoc->stream before updating stream > info when processing dupcookie, b

Re: [PATCH net 1/2] sctp: fix stream update when processing dupcookie

2017-05-23 Thread Neil Horman
On Tue, May 23, 2017 at 01:28:54PM +0800, Xin Long wrote: > Since commit 3dbcc105d556 ("sctp: alloc stream info when initializing > asoc"), stream and stream.out info are always alloced when creating > an asoc. > > So it's not correct to check !asoc->stream before updating stream > info when proce

[PATCH net 1/2] sctp: fix stream update when processing dupcookie

2017-05-22 Thread Xin Long
Since commit 3dbcc105d556 ("sctp: alloc stream info when initializing asoc"), stream and stream.out info are always alloced when creating an asoc. So it's not correct to check !asoc->stream before updating stream info when processing dupcookie, but would be better to check asoc state instead. Fix