Re: [PATCH net 1/2] rds: tcp: use sock_create_lite() to create the accept socket

On 7/6/2017 8:15 AM, Sowmini Varadhan wrote: There are two problems with calling sock_create_kern() from rds_tcp_accept_one() 1. it sets up a new_sock->sk that is wasteful, because this ->sk is going to get replaced by inet_accept() in the subsequent ->accept() 2. The new_sock->sk is a leaked

[PATCH net 1/2] rds: tcp: use sock_create_lite() to create the accept socket

There are two problems with calling sock_create_kern() from rds_tcp_accept_one() 1. it sets up a new_sock->sk that is wasteful, because this ->sk is going to get replaced by inet_accept() in the subsequent ->accept() 2. The new_sock->sk is a leaked reference in sock_graft() which expects to f