RE: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-08 Thread Keller, Jacob E
er, Jacob E ; > mtosa...@redhat.com > Subject: Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct > ptp_sys_offset_extended > > On Mon, Jan 07, 2019 at 09:19:23PM -0800, Richard Cochran wrote: > > On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote: &g

Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-08 Thread Eugene Syromiatnikov
On Mon, Jan 07, 2019 at 09:19:23PM -0800, Richard Cochran wrote: > On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote: > > From: Eugene Syromiatnikov > > Date: Mon, 7 Jan 2019 16:22:29 +0100 > > > > > Otherwise it is impossible to use it for something else, as it will break > > > usersp

Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-07 Thread Richard Cochran
On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote: > From: Eugene Syromiatnikov > Date: Mon, 7 Jan 2019 16:22:29 +0100 > > > Otherwise it is impossible to use it for something else, as it will break > > userspace that puts garbage there. > > > > The same check should be done in other

Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-07 Thread David Miller
From: Miroslav Lichvar Date: Mon, 7 Jan 2019 17:57:41 +0100 > On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote: >> From: Eugene Syromiatnikov >> Date: Mon, 7 Jan 2019 16:22:29 +0100 >> >> > Otherwise it is impossible to use it for something else, as it will break >> > userspace that

Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-07 Thread Miroslav Lichvar
On Mon, Jan 07, 2019 at 08:29:38AM -0800, David Miller wrote: > From: Eugene Syromiatnikov > Date: Mon, 7 Jan 2019 16:22:29 +0100 > > > Otherwise it is impossible to use it for something else, as it will break > > userspace that puts garbage there. > > > > The same check should be done in other

Re: [PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-07 Thread David Miller
From: Eugene Syromiatnikov Date: Mon, 7 Jan 2019 16:22:29 +0100 > Otherwise it is impossible to use it for something else, as it will break > userspace that puts garbage there. > > The same check should be done in other structures, but the fact that > data in reserved fields is ignored is alread

[PATCH net 1/2] ptp: check that rsv field is zero in struct ptp_sys_offset_extended

2019-01-07 Thread Eugene Syromiatnikov
Otherwise it is impossible to use it for something else, as it will break userspace that puts garbage there. The same check should be done in other structures, but the fact that data in reserved fields is ignored is already part of the kernel ABI. Signed-off-by: Eugene Syromiatnikov --- drivers