Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-19 Thread Taehee Yoo
On Wed, 19 Dec 2018 at 07:51, David Miller wrote: > > From: Taehee Yoo > Date: Mon, 17 Dec 2018 16:31:04 +0900 > > > But I don't know how cleanup callback is invoked when > > bpfilter_umh process is killed. > > I am suggesting that a new piece of generic infrastructure might > be needed, but it w

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-18 Thread David Miller
From: Taehee Yoo Date: Mon, 17 Dec 2018 16:31:04 +0900 > But I don't know how cleanup callback is invoked when > bpfilter_umh process is killed. I am suggesting that a new piece of generic infrastructure might be needed, but it would need to be carefully designed. The task_struct would get a pi

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-16 Thread Taehee Yoo
On Mon, 17 Dec 2018 at 07:20, David Miller wrote: > > From: Taehee Yoo > Date: Sat, 15 Dec 2018 13:22:39 +0900 > > > If bpfilter_umh process is killed, shutdown_umh() is executed via > > __stop_umh(). > > because, __kernel_write() or kernel_read() will be failed in > > __bpfilter_process_sockopt

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-16 Thread David Miller
From: Taehee Yoo Date: Sat, 15 Dec 2018 13:22:39 +0900 > If bpfilter_umh process is killed, shutdown_umh() is executed via > __stop_umh(). > because, __kernel_write() or kernel_read() will be failed in > __bpfilter_process_sockopt() if bpfilter_umh process had killed > or crashed. then, __bpfilt

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-14 Thread Taehee Yoo
On Sat, 15 Dec 2018 at 09:58, David Miller wrote: > > From: Taehee Yoo > Date: Wed, 12 Dec 2018 10:19:26 +0900 > > > When bpfilter error occurred bpfilter_umh will be stopped via __stop_umh(). > > The bpfilter_umh() couldn't start again because there is no restart > > routine. > > > > The section

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-14 Thread David Miller
From: Taehee Yoo Date: Wed, 12 Dec 2018 10:19:26 +0900 > When bpfilter error occurred bpfilter_umh will be stopped via __stop_umh(). > The bpfilter_umh() couldn't start again because there is no restart > routine. > > The section of bpfilter_umh_{start/end} is no longer .init.rodata > because th

[PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-11 Thread Taehee Yoo
When bpfilter error occurred bpfilter_umh will be stopped via __stop_umh(). The bpfilter_umh() couldn't start again because there is no restart routine. The section of bpfilter_umh_{start/end} is no longer .init.rodata because these area should be reused in the restart routine. hence the section n