Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-28 Thread Paolo Abeni
On Thu, 2016-01-28 at 07:59 -0700, David Ahern wrote: > On 1/27/16 6:45 AM, Paolo Abeni wrote: > > The current implementation of ip6_dst_lookup_tail() basically > > ignore the egress ifindex match: if the saddr is set, > > ip6_route_output() purposefully ignores flowi6_oif, due > > to the commit d4

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-28 Thread David Ahern
On 1/27/16 6:45 AM, Paolo Abeni wrote: The current implementation of ip6_dst_lookup_tail() basically ignore the egress ifindex match: if the saddr is set, ip6_route_output() purposefully ignores flowi6_oif, due to the commit d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if saddr set"

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-28 Thread Hannes Frederic Sowa
On 28.01.2016 13:27, Paolo Abeni wrote: On Wed, 2016-01-27 at 19:38 +0100, Hannes Frederic Sowa wrote: On 27.01.2016 14:45, Paolo Abeni wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 3c8834b..973cb73 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1183,11 +1183,10 @@ sta

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-28 Thread Paolo Abeni
On Wed, 2016-01-27 at 19:38 +0100, Hannes Frederic Sowa wrote: > On 27.01.2016 14:45, Paolo Abeni wrote: > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > > index 3c8834b..973cb73 100644 > > --- a/net/ipv6/route.c > > +++ b/net/ipv6/route.c > > @@ -1183,11 +1183,10 @@ static struct rt6_info *i

Re: [PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-27 Thread Hannes Frederic Sowa
On 27.01.2016 14:45, Paolo Abeni wrote: diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 3c8834b..973cb73 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -1183,11 +1183,10 @@ static struct rt6_info *ip6_pol_route_output(struct net *net, struct fib6_table return ip6_pol_rout

[PATCH net 1/2] ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()

2016-01-27 Thread Paolo Abeni
The current implementation of ip6_dst_lookup_tail() basically ignore the egress ifindex match: if the saddr is set, ip6_route_output() purposefully ignores flowi6_oif, due to the commit d46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if saddr set"), if the saddr is 'any' the first route