Re: [PATCH net 1/1 v3] rtnetlink: require unique netns identifier

2018-02-07 Thread Eric W. Biederman
Christian Brauner writes: > On Wed, Feb 07, 2018 at 12:19:25PM +0100, Jiri Benc wrote: >> On Tue, 6 Feb 2018 14:19:02 +0100, Christian Brauner wrote: >> > +/* Verify that rtnetlink requests supporting network namespace ids >> > + * do not pass additional properties potentially referring to diffe

Re: [PATCH net 1/1 v3] rtnetlink: require unique netns identifier

2018-02-07 Thread Christian Brauner
On Wed, Feb 07, 2018 at 12:19:25PM +0100, Jiri Benc wrote: > On Tue, 6 Feb 2018 14:19:02 +0100, Christian Brauner wrote: > > +/* Verify that rtnetlink requests supporting network namespace ids > > + * do not pass additional properties potentially referring to different > > + * network namespaces.

Re: [PATCH net 1/1 v3] rtnetlink: require unique netns identifier

2018-02-07 Thread Jiri Benc
On Tue, 6 Feb 2018 14:19:02 +0100, Christian Brauner wrote: > +/* Verify that rtnetlink requests supporting network namespace ids > + * do not pass additional properties potentially referring to different > + * network namespaces. > + */ > +static int rtnl_ensure_unique_netns(struct nlattr *tb[],

[PATCH net 1/1 v3] rtnetlink: require unique netns identifier

2018-02-06 Thread Christian Brauner
Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK it is possible for userspace to send us requests with three different properties to identify a target network namespace. This affects at least RTM_{NEW,SET}LINK. Each of them could potentially refer to a different network n