Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-04 Thread David Ahern
On 2/4/18 5:11 AM, Christian Brauner wrote: > On Sat, Feb 03, 2018 at 11:17:01AM -0800, Stephen Hemminger wrote: >> On Sat, 3 Feb 2018 14:29:04 +0100 >> Christian Brauner wrote: >> >>> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, >>> +struct

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-04 Thread Christian Brauner
On Sat, Feb 03, 2018 at 07:09:55PM -0700, David Ahern wrote: > On 2/3/18 12:17 PM, Stephen Hemminger wrote: > > On Sat, 3 Feb 2018 14:29:04 +0100 > > Christian Brauner wrote: > > > >> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, > >> + struct

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-04 Thread Christian Brauner
On Sat, Feb 03, 2018 at 11:17:01AM -0800, Stephen Hemminger wrote: > On Sat, 3 Feb 2018 14:29:04 +0100 > Christian Brauner wrote: > > > +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, > > +struct nlattr *tb[], > > +

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-03 Thread David Ahern
On 2/3/18 12:17 PM, Stephen Hemminger wrote: > On Sat, 3 Feb 2018 14:29:04 +0100 > Christian Brauner wrote: > >> +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, >> + struct nlattr *tb[], >> + struct netlink_

Re: [PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-03 Thread Stephen Hemminger
On Sat, 3 Feb 2018 14:29:04 +0100 Christian Brauner wrote: > +static int rtnl_ensure_unique_netns_attr(const struct sock *sk, > + struct nlattr *tb[], > + struct netlink_ext_ack *extack) > +{ > + int ret = -EINVAL; > +

[PATCH net 1/1 v1] rtnetlink: require unique netns identifier

2018-02-03 Thread Christian Brauner
Since we've added support for IFLA_IF_NETNSID for RTM_{DEL,GET,SET,NEW}LINK it is possible for userspace to send us requests with three different properties to identify a target network namespace. This affects at least RTM_{NEW,SET}LINK. Each of them could potentially refer to a different network n