gt;> Envoyé: Dimanche 24 Janvier 2021 05:54:44
> >> Objet: Re: [PATCH net 1/1] uapi: fix big endian definition of
> >> ipv6_rpl_sr_hdr
> >
> >> On Thu, 21 Jan 2021 23:00:44 +0100 Justin Iurman wrote:
> >>> Following RF
tdev@vger.kernel.org, da...@davemloft.net, "alex aring"
>>>>
>>>> Envoyé: Dimanche 24 Janvier 2021 05:54:44
>>>> Objet: Re: [PATCH net 1/1] uapi: fix big endian definition of
>>>> ipv6_rpl_sr_hdr
>>>
>>>>>
On Mon, 25 Jan 2021 22:11:35 +0100 (CET) Justin Iurman wrote:
> >>> If you meant the old/current one, well, I don't understand why the big
> >>> endian definition would look like this:
> >>>
> >>> #elif defined(__BIG_ENDIAN_BITFIELD)
> >>>__u32reserved:20,
> >>>pad:4,
> >>>
On Mon, 25 Jan 2021 13:12:42 -0700 David Ahern wrote:
> On 1/25/21 12:32 PM, Jakub Kicinski wrote:
> > diff --git a/include/uapi/linux/rpl.h b/include/uapi/linux/rpl.h
> > index 1dccb55cf8c6..708adddf9f13 100644
> > --- a/include/uapi/linux/rpl.h
> > +++ b/include/uapi/linux/rpl.h
>
On 1/25/21 12:32 PM, Jakub Kicinski wrote:
> diff --git a/include/uapi/linux/rpl.h b/include/uapi/linux/rpl.h
> index 1dccb55cf8c6..708adddf9f13 100644
> --- a/include/uapi/linux/rpl.h
> +++ b/include/uapi/linux/rpl.h
> @@ -28,10 +28,10 @@ struct ipv6_rpl_sr_hdr {
>
On 1/24/21 2:57 AM, Justin Iurman wrote:
>> De: "Jakub Kicinski"
>> À: "Justin Iurman"
>> Cc: netdev@vger.kernel.org, da...@davemloft.net, "alex aring"
>>
>> Envoyé: Dimanche 24 Janvier 2021 05:54:44
>> Objet: Re: [PATCH net 1/
> De: "Jakub Kicinski"
> À: "Justin Iurman"
> Cc: netdev@vger.kernel.org, da...@davemloft.net, "alex aring"
>
> Envoyé: Dimanche 24 Janvier 2021 05:54:44
> Objet: Re: [PATCH net 1/1] uapi: fix big endian definition of ipv6_rpl_sr_hdr
> On
On Thu, 21 Jan 2021 23:00:44 +0100 Justin Iurman wrote:
> Following RFC 6554 [1], the current order of fields is wrong for big
> endian definition. Indeed, here is how the header looks like:
>
> +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> | Next Header | Hdr Ext Len | R
Following RFC 6554 [1], the current order of fields is wrong for big
endian definition. Indeed, here is how the header looks like:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
| Next Header | Hdr Ext Len | Routing Type | Segments Left |
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
