RE: [PATCH net 1/1] tipc: revert use of copy_from_iter_full()

2016-12-22 Thread Jon Maloy
gt; ; Ying Xue > ; ma...@donjonn.com; tipc- > discuss...@lists.sourceforge.net > Subject: Re: [PATCH net 1/1] tipc: revert use of copy_from_iter_full() > > On Thu, Dec 22, 2016 at 02:47:09AM +, Jon Maloy wrote: > > > > OK, I see what's going on there - unlike iterate_and_adv

RE: [PATCH net 1/1] tipc: revert use of copy_from_iter_full()

2016-12-21 Thread Jon Maloy
.com; tipc- > discuss...@lists.sourceforge.net > Subject: Re: [PATCH net 1/1] tipc: revert use of copy_from_iter_full() > > On Thu, Dec 22, 2016 at 01:21:01AM +, Al Viro wrote: > > On Wed, Dec 21, 2016 at 08:01:37PM -0500, Jon Maloy wrote: > > > commit cbbd26b8b1a6 ("[iov_i

Re: [PATCH net 1/1] tipc: revert use of copy_from_iter_full()

2016-12-21 Thread Al Viro
On Thu, Dec 22, 2016 at 02:47:09AM +, Jon Maloy wrote: > > OK, I see what's going on there - unlike iterate_and_advance(), which > > explicitly skips any work in case of empty iterator, iterate_all_kind() > > does not. Could you check if the following fixes your problem? > > Confirmed. The c

Re: [PATCH net 1/1] tipc: revert use of copy_from_iter_full()

2016-12-21 Thread Al Viro
On Wed, Dec 21, 2016 at 08:01:37PM -0500, Jon Maloy wrote: > commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() > and friends") replaced calls to copy_from_iter() in the function > tipc_msg_build(). This causes a an immediate crash as follows: Very interesting. > [ 1209.59707

Re: [PATCH net 1/1] tipc: revert use of copy_from_iter_full()

2016-12-21 Thread Al Viro
On Thu, Dec 22, 2016 at 01:21:01AM +, Al Viro wrote: > On Wed, Dec 21, 2016 at 08:01:37PM -0500, Jon Maloy wrote: > > commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() > > and friends") replaced calls to copy_from_iter() in the function > > tipc_msg_build(). This causes a

[PATCH net 1/1] tipc: revert use of copy_from_iter_full()

2016-12-21 Thread Jon Maloy
commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full() and friends") replaced calls to copy_from_iter() in the function tipc_msg_build(). This causes a an immediate crash as follows: [ 1209.597076] BUG: unable to handle kernel NULL pointer dereference at 0008 [ 1209.6