Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-24 Thread sundeep subbaraya
Hi David, On Sat, Jul 25, 2020 at 8:40 AM David Miller wrote: > > From: sundeep subbaraya > Date: Fri, 24 Jul 2020 08:40:44 +0530 > > > On Fri, Jul 24, 2020 at 12:43 AM David Miller wrote: > >> > >> If you leave interrupts on then an interrupt can arrive after the software > >> state has been r

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-24 Thread David Miller
From: sundeep subbaraya Date: Fri, 24 Jul 2020 08:40:44 +0530 > On Fri, Jul 24, 2020 at 12:43 AM David Miller wrote: >> >> If you leave interrupts on then an interrupt can arrive after the software >> state has been released by unregister_netdev. >> >> Sounds like you need to resolve this some o

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-23 Thread sundeep subbaraya
Hi David, On Fri, Jul 24, 2020 at 12:43 AM David Miller wrote: > > From: sundeep subbaraya > Date: Thu, 23 Jul 2020 20:29:03 +0530 > > > Hi David, > > > > On Wed, Jul 22, 2020 at 7:34 PM sundeep subbaraya > > wrote: > >> > >> Hi David, > >> > >> On Wed, Jul 22, 2020 at 4:47 AM David Miller wro

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-23 Thread David Miller
From: sundeep subbaraya Date: Thu, 23 Jul 2020 20:29:03 +0530 > Hi David, > > On Wed, Jul 22, 2020 at 7:34 PM sundeep subbaraya > wrote: >> >> Hi David, >> >> On Wed, Jul 22, 2020 at 4:47 AM David Miller wrote: >> > >> > From: sundeep.l...@gmail.com >> > Date: Tue, 21 Jul 2020 22:44:05 +0530 >

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-23 Thread sundeep subbaraya
Hi David, On Wed, Jul 22, 2020 at 7:34 PM sundeep subbaraya wrote: > > Hi David, > > On Wed, Jul 22, 2020 at 4:47 AM David Miller wrote: > > > > From: sundeep.l...@gmail.com > > Date: Tue, 21 Jul 2020 22:44:05 +0530 > > > > > Subbaraya Sundeep (3): > > > octeontx2-pf: Fix reset_task bugs > > >

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-22 Thread sundeep subbaraya
Hi David, On Wed, Jul 22, 2020 at 4:47 AM David Miller wrote: > > From: sundeep.l...@gmail.com > Date: Tue, 21 Jul 2020 22:44:05 +0530 > > > Subbaraya Sundeep (3): > > octeontx2-pf: Fix reset_task bugs > > octeontx2-pf: cancel reset_task work > > octeontx2-pf: Unregister netdev at driver re

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-21 Thread David Miller
From: sundeep.l...@gmail.com Date: Tue, 21 Jul 2020 22:44:05 +0530 > Subbaraya Sundeep (3): > octeontx2-pf: Fix reset_task bugs > octeontx2-pf: cancel reset_task work > octeontx2-pf: Unregister netdev at driver remove I think you should shut down all the interrupts and other state before un

[PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-21 Thread sundeep . lkml
From: Subbaraya Sundeep Hi, There are problems in the existing Octeontx2 netdev drivers like missing cancel_work for the reset task, missing lock in reset task and missing unergister_netdev in driver remove. This patch set fixes the above problems. Thanks, Sundeep Subbaraya Sundeep (3): octe