Re: [PATCH net 0/2] NULL pointer dereference in {ipvlan|macvlan}_port_destroy

2017-11-03 Thread Girish Moodalbail
On 11/2/17 10:05 PM, David Miller wrote: From: Girish Moodalbail Date: Tue, 31 Oct 2017 09:39:45 -0700 When call to register_netdevice() (called from ipvlan_link_new()) fails, inside that function we call ipvlan_uninit() (through ndo_uninit()) to destroy the ipvlan port. Upon returning unsucce

Re: [PATCH net 0/2] NULL pointer dereference in {ipvlan|macvlan}_port_destroy

2017-11-02 Thread David Miller
From: Girish Moodalbail Date: Tue, 31 Oct 2017 09:39:45 -0700 > When call to register_netdevice() (called from ipvlan_link_new()) > fails, inside that function we call ipvlan_uninit() (through > ndo_uninit()) to destroy the ipvlan port. Upon returning > unsuccessfully from register_netdevice() we

[PATCH net 0/2] NULL pointer dereference in {ipvlan|macvlan}_port_destroy

2017-10-31 Thread Girish Moodalbail
>From code inspection it appeared that there is a possibility where in ipvlan_port_destroy() might be dealing with a port (struct ipvl_port) that has already been destroyed and is therefore already NULL. However, we don't check for NULL and continue to access the fields which results in a kernel pa