Re: [PATCH net 0/2] Fix vlan untag and insertion for bridge and vlan with reorder_hdr off

2018-03-28 Thread Toshiaki Makita
On 2018/03/28 15:11, Eric Dumazet wrote: > On 03/16/2018 07:05 AM, David Miller wrote: >> From: Toshiaki Makita >> Date: Tue, 13 Mar 2018 14:51:26 +0900 >> >>> As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from >>> bridge devices ends up with corrupted packets. He narrowed d

Re: [PATCH net 0/2] Fix vlan untag and insertion for bridge and vlan with reorder_hdr off

2018-03-27 Thread Eric Dumazet
On 03/16/2018 07:05 AM, David Miller wrote: > From: Toshiaki Makita > Date: Tue, 13 Mar 2018 14:51:26 +0900 > >> As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from >> bridge devices ends up with corrupted packets. He narrowed down this problem >> and found that the root c

Re: [PATCH net 0/2] Fix vlan untag and insertion for bridge and vlan with reorder_hdr off

2018-03-16 Thread David Miller
From: Toshiaki Makita Date: Tue, 13 Mar 2018 14:51:26 +0900 > As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from > bridge devices ends up with corrupted packets. He narrowed down this problem > and found that the root cause is in skb_reorder_vlan_header(). > > While I was

[PATCH net 0/2] Fix vlan untag and insertion for bridge and vlan with reorder_hdr off

2018-03-12 Thread Toshiaki Makita
As Brandon Carpenter reported[1], sending non-vlan-offloaded packets from bridge devices ends up with corrupted packets. He narrowed down this problem and found that the root cause is in skb_reorder_vlan_header(). While I was working on fixing this problem, I found that the function does not work