Re: [Intel-wired-lan] [PATCH net-queue] i40e: Fix incorrect skb reserved size on rx

2018-06-14 Thread Toshiaki Makita
On 2018/06/14 18:14, Malek, Patryk wrote: >> On 2018/06/13 18:06, Daniel Borkmann wrote: >>> On 06/13/2018 10:08 AM, Toshiaki Makita wrote: i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data - xdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary >> here and mac_header/dat

RE: [Intel-wired-lan] [PATCH net-queue] i40e: Fix incorrect skb reserved size on rx

2018-06-14 Thread Malek, Patryk
> On 2018/06/13 18:06, Daniel Borkmann wrote: > > On 06/13/2018 10:08 AM, Toshiaki Makita wrote: > >> i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data - > >> xdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary > here > >> and mac_header/data feilds in skb becomes incorrect, and break

Re: [PATCH net-queue] i40e: Fix incorrect skb reserved size on rx

2018-06-13 Thread Toshiaki Makita
On 2018/06/13 18:06, Daniel Borkmann wrote: > On 06/13/2018 10:08 AM, Toshiaki Makita wrote: >> i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data - >> xdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary here >> and mac_header/data feilds in skb becomes incorrect, and breaks normal >>

Re: [PATCH net-queue] i40e: Fix incorrect skb reserved size on rx

2018-06-13 Thread Daniel Borkmann
On 06/13/2018 10:08 AM, Toshiaki Makita wrote: > i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data - > xdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary here > and mac_header/data feilds in skb becomes incorrect, and breaks normal > skb receive path as well as XDP receive path. > >

[PATCH net-queue] i40e: Fix incorrect skb reserved size on rx

2018-06-13 Thread Toshiaki Makita
i40e_build_skb() reserves I40E_SKB_PAD + (xdp->data - xdp->data_hard_start) but obviously I40E_SKB_PAD is unnecessary here and mac_header/data feilds in skb becomes incorrect, and breaks normal skb receive path as well as XDP receive path. Fixes: cc5b114dcf98 ("bpf, i40e: add meta data support") S