RE: [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-27 Thread Brown, Aaron F
ileo.org; jakub.kicin...@netronome.com; m-kariche...@ti.com; > sergei.shtyl...@cogentembedded.com; eric.duma...@gmail.com; Brown, > Aaron F ; Patel, Vedang > Subject: [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the > txtime > > If a packet which is utilizing th

Re: [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-26 Thread Patel, Vedang
Hi Jeff, > On Jun 26, 2019, at 12:44 PM, Kirsher, Jeffrey T > wrote: > > On Tue, 2019-06-25 at 15:07 -0700, Vedang Patel wrote: >> If a packet which is utilizing the launchtime feature (via SO_TXTIME >> socket >> option) also requests the hardware transmit timestamp, the hardware >> timestamp i

Re: [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-26 Thread Jeff Kirsher
On Tue, 2019-06-25 at 15:07 -0700, Vedang Patel wrote: > If a packet which is utilizing the launchtime feature (via SO_TXTIME > socket > option) also requests the hardware transmit timestamp, the hardware > timestamp is not delivered to the userspace. This is because the > value in > skb->tstamp is

[PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime

2019-06-25 Thread Vedang Patel
If a packet which is utilizing the launchtime feature (via SO_TXTIME socket option) also requests the hardware transmit timestamp, the hardware timestamp is not delivered to the userspace. This is because the value in skb->tstamp is mistaken as the software timestamp. Applications, like ptp4l, req