Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-21 Thread Henrik Bjoernlund
Thank you for the review. Comments below. The 10/19/2020 09:21, Jakub Kicinski wrote:> > On Mon, 19 Oct 2020 08:51:04 + Henrik Bjoernlund wrote: > > Thank you for the review. Comments below. > > > > The 10/15/2020 10:34, Jakub Kicinski wrote: > > > > > > On Thu, 15 Oct 2020 11:54:15 + Hen

Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-19 Thread Jakub Kicinski
On Mon, 19 Oct 2020 08:51:04 + Henrik Bjoernlund wrote: > Thank you for the review. Comments below. > > The 10/15/2020 10:34, Jakub Kicinski wrote: > > > > On Thu, 15 Oct 2020 11:54:15 + Henrik Bjoernlund wrote: > > > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > > > + .type

Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-19 Thread Henrik Bjoernlund
Thank you for the review. Comments below. The 10/15/2020 10:34, Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 11:54:15 + Henrik Bjoernlund wrote: > > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 }, > > NLA

Re: [PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-15 Thread Jakub Kicinski
On Thu, 15 Oct 2020 11:54:15 + Henrik Bjoernlund wrote: > + [IFLA_BRIDGE_CFM_MEP_CONFIG_MDLEVEL] = { > + .type = NLA_U32, .validation_type = NLA_VALIDATE_MAX, .max = 7 }, NLA_POLICY_MAX(NLA_U32, 7) Also why did you keep the validation in the code in patch 4?

[PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
This is the implementation of CFM netlink configuration set information interface. Add new nested netlink attributes. These attributes are used by the user space to create/delete/configure CFM instances. SETLINK: IFLA_BRIDGE_CFM: Indicate that the following attributes are CFM. IF