Re: [PATCH net-next v6] mpls: support for dead routes

2015-12-01 Thread roopa
On 12/1/15, 12:43 PM, David Miller wrote: > From: Roopa Prabhu > Date: Sat, 28 Nov 2015 19:38:33 -0800 > >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >> routes due to link events. Also adds code to ignore dead >> routes during route selection. > I agree with Robert's feedback

Re: [PATCH net-next v6] mpls: support for dead routes

2015-12-01 Thread David Miller
From: Roopa Prabhu Date: Sat, 28 Nov 2015 19:38:33 -0800 > Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls > routes due to link events. Also adds code to ignore dead > routes during route selection. I agree with Robert's feedback that we probably should use ACCESS_ONCE(), optional

Re: [PATCH net-next v6] mpls: support for dead routes

2015-11-30 Thread Robert Shearman
On 29/11/15 03:38, Roopa Prabhu wrote: From: Roopa Prabhu } } - nh_index = hash % rt->rt_nhn; + return hash; +} + +static struct mpls_nh *mpls_select_multipath(struct mpls_route *rt, +struct sk_buff *skb, bool bos)

[PATCH net-next v6] mpls: support for dead routes

2015-11-28 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is current mpls behaviour and this patch does not