On Tue, May 1, 2018 at 12:12 PM, Eric Dumazet wrote:
>
> I guess that nobody really wants to really review Cake if
> it is a file with 2700 lines of code and hundreds of variables/tunables.
>
> Sure, we have big files in networking land, as a result of thousands of
> changes.
>
> If you split it,
Eric Dumazet writes:
> On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote:
>
>> Could you comment on specifically what you believe is broken in this,
>> please, so I can fix it in the same iteration?
>>
>
> Apart from the various pskb_may_pull() this helper should not change skb
> layout.
>
>
On 05/01/2018 12:31 PM, Toke Høiland-Jørgensen wrote:
> Could you comment on specifically what you believe is broken in this,
> please, so I can fix it in the same iteration?
>
Apart from the various pskb_may_pull() this helper should not change skb layout.
Ideally, the skb should be const an
Eric Dumazet writes:
> On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote:
>
>> *sigh* - can do, I guess. Though I'm not sure what that is going to
>> accomplish, exactly?
>
>
> I guess that nobody really wants to really review Cake if
> it is a file with 2700 lines of code and hundreds of vari
On Tue, May 1, 2018 at 11:53 AM, Toke Høiland-Jørgensen wrote:
> Eric Dumazet writes:
>
>> On 04/30/2018 02:27 PM, Dave Taht wrote:
>>
>>> I actually have a tc - bpf based ack filter, during the development of
>>> cake's ack-thinner, that I should submit one of these days. It
>>> proved to be of
From: Eric Dumazet
Date: Tue, 1 May 2018 12:12:45 -0700
> It seems you guys spent years/months on work on this stuff, so what
> is the big deal about presenting your work in the best possible way
> ?
+1
On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote:
> *sigh* - can do, I guess. Though I'm not sure what that is going to
> accomplish, exactly?
I guess that nobody really wants to really review Cake if
it is a file with 2700 lines of code and hundreds of variables/tunables.
Sure, we have b
Eric Dumazet writes:
> On 04/30/2018 02:27 PM, Dave Taht wrote:
>
>> I actually have a tc - bpf based ack filter, during the development of
>> cake's ack-thinner, that I should submit one of these days. It
>> proved to be of limited use.
>>
>> Probably the biggest mistake we made is by calling t
> On 1 May, 2018, at 7:06 pm, Eric Dumazet wrote:
>
> You have not provided any numbers to show how useful it is to maintain this
> code (probably still broken btw, considering it is changing some skb
> attributes).
A simple calculation shows what the maximum tolerable asymmetry for a
conventi
On 04/30/2018 02:27 PM, Dave Taht wrote:
> I actually have a tc - bpf based ack filter, during the development of
> cake's ack-thinner, that I should submit one of these days. It
> proved to be of limited use.
>
> Probably the biggest mistake we made is by calling this cake feature a
> filter.
Cong Wang writes:
> On Mon, Apr 30, 2018 at 2:27 PM, Dave Taht wrote:
>> On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote:
>>> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen
>>> wrote:
sch_cake targets the home router use case and is intended to squeeze the
most bandwidth a
On Mon, Apr 30, 2018 at 2:27 PM, Dave Taht wrote:
> On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote:
>> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote:
>>> sch_cake targets the home router use case and is intended to squeeze the
>>> most bandwidth and latency out of even the slow
On Mon, Apr 30, 2018 at 2:21 PM, Cong Wang wrote:
> On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote:
>> sch_cake targets the home router use case and is intended to squeeze the
>> most bandwidth and latency out of even the slowest ISP links and routers,
>> while presenting an API si
On Sun, Apr 29, 2018 at 2:34 PM, Toke Høiland-Jørgensen wrote:
> sch_cake targets the home router use case and is intended to squeeze the
> most bandwidth and latency out of even the slowest ISP links and routers,
> while presenting an API simple enough that even an ISP can configure it.
>
> Examp
sch_cake targets the home router use case and is intended to squeeze the
most bandwidth and latency out of even the slowest ISP links and routers,
while presenting an API simple enough that even an ISP can configure it.
Example of use on a cable ISP uplink:
tc qdisc add dev eth0 cake bandwidth 20
15 matches
Mail list logo
