Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

2018-07-30 Thread David Miller
From: Jiri Pirko Date: Mon, 30 Jul 2018 18:49:23 +0200 > So the changelog stays in the commit message, right? Yes.

Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

2018-07-30 Thread Jiri Pirko
Mon, Jul 30, 2018 at 06:31:00PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Mon, 30 Jul 2018 14:40:13 +0200 > >> Oh, another nitpick: The changelog should go under "---" line. That way, >> the maintainer does not have to deal with it during apply (git apply >> will cut it out). > >I

Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

2018-07-30 Thread David Miller
From: Jiri Pirko Date: Mon, 30 Jul 2018 14:40:13 +0200 > Oh, another nitpick: The changelog should go under "---" line. That way, > the maintainer does not have to deal with it during apply (git apply > will cut it out). I actually like the changelog to be _IN_ the commit message. It's useful i

Re: [PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

2018-07-30 Thread Jiri Pirko
Mon, Jul 30, 2018 at 02:30:44PM CEST, pab...@redhat.com wrote: >This is similar TC_ACT_REDIRECT, but with a slightly different >semantic: >- on ingress the mirred skbs are passed to the target device >network stack without any additional check not scrubbing. >- the rcu-protected stats provided via

[PATCH net-next v5 3/4] net/tc: introduce TC_ACT_REINSERT.

2018-07-30 Thread Paolo Abeni
This is similar TC_ACT_REDIRECT, but with a slightly different semantic: - on ingress the mirred skbs are passed to the target device network stack without any additional check not scrubbing. - the rcu-protected stats provided via the tcf_result struct are updated on error conditions. This new t