Re: [PATCH net-next v5 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-27 Thread Nikolay Aleksandrov
On 27/10/17 11:24, Toshiaki Makita wrote: > On 2017/10/26 22:41, Nikolay Aleksandrov wrote: >> Before this patch there was no way to tell if the vlan add operation >> actually changed anything, thus we would always generate a notification >> on adds. Let's make the notifications more precise and ge

Re: [PATCH net-next v5 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-27 Thread Toshiaki Makita
On 2017/10/26 22:41, Nikolay Aleksandrov wrote: > Before this patch there was no way to tell if the vlan add operation > actually changed anything, thus we would always generate a notification > on adds. Let's make the notifications more precise and generate them > only if anything changed, so use

Re: [PATCH net-next v5 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-27 Thread Nikolay Aleksandrov
On 27/10/17 04:55, Toshiaki Makita wrote: > On 2017/10/26 22:41, Nikolay Aleksandrov wrote: >> Before this patch there was no way to tell if the vlan add operation >> actually changed anything, thus we would always generate a notification >> on adds. Let's make the notifications more precise and ge

Re: [PATCH net-next v5 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-26 Thread Toshiaki Makita
On 2017/10/26 22:41, Nikolay Aleksandrov wrote: > Before this patch there was no way to tell if the vlan add operation > actually changed anything, thus we would always generate a notification > on adds. Let's make the notifications more precise and generate them > only if anything changed, so use

[PATCH net-next v5 2/2] bridge: vlan: signal if anything changed on vlan add

2017-10-26 Thread Nikolay Aleksandrov
Before this patch there was no way to tell if the vlan add operation actually changed anything, thus we would always generate a notification on adds. Let's make the notifications more precise and generate them only if anything changed, so use the new bool parameter to signal that the vlan was updat