Re: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-20 Thread Jakub Kicinski
On Sat, Jan 20, 2018 at 2:54 AM, Jiri Pirko wrote: > Sat, Jan 20, 2018 at 11:33:31AM CET, jakub.kicin...@netronome.com wrote: >>On Sat, Jan 20, 2018 at 2:22 AM, Jiri Pirko wrote: >>> Sat, Jan 20, 2018 at 11:12:25AM CET, jakub.kicin...@netronome.com wrote: net/sched/sch_prio.c: if (!tc_can_o

Re: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-20 Thread Jiri Pirko
Sat, Jan 20, 2018 at 11:33:31AM CET, jakub.kicin...@netronome.com wrote: >On Sat, Jan 20, 2018 at 2:22 AM, Jiri Pirko wrote: >> Sat, Jan 20, 2018 at 11:12:25AM CET, jakub.kicin...@netronome.com wrote: >>>net/sched/sch_prio.c: if (!tc_can_offload(dev) || >>>!dev->netdev_ops->ndo_setup_tc) >>>net/

Re: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-20 Thread Jakub Kicinski
On Sat, Jan 20, 2018 at 2:22 AM, Jiri Pirko wrote: > Sat, Jan 20, 2018 at 11:12:25AM CET, jakub.kicin...@netronome.com wrote: >>net/sched/sch_prio.c: if (!tc_can_offload(dev) || >>!dev->netdev_ops->ndo_setup_tc) >>net/sched/sch_prio.c: if (!tc_can_offload(dev) || >>!dev->netdev_ops->ndo_setup_

Re: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-20 Thread Jiri Pirko
Sat, Jan 20, 2018 at 11:12:25AM CET, jakub.kicin...@netronome.com wrote: >On Sat, Jan 20, 2018 at 12:59 AM, Jiri Pirko wrote: >> Sat, Jan 20, 2018 at 02:44:48AM CET, jakub.kicin...@netronome.com wrote: >>>From: Quentin Monnet >>> >>>Create a wrapper around tc_can_offload() that takes an additiona

Re: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-20 Thread Jakub Kicinski
On Sat, Jan 20, 2018 at 12:59 AM, Jiri Pirko wrote: > Sat, Jan 20, 2018 at 02:44:48AM CET, jakub.kicin...@netronome.com wrote: >>From: Quentin Monnet >> >>Create a wrapper around tc_can_offload() that takes an additional >>extack pointer argument in order to output an error message if TC >>offloa

Re: [PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-20 Thread Jiri Pirko
Sat, Jan 20, 2018 at 02:44:48AM CET, jakub.kicin...@netronome.com wrote: >From: Quentin Monnet > >Create a wrapper around tc_can_offload() that takes an additional >extack pointer argument in order to output an error message if TC >offload is disabled on the device. > >In this way, the error messa

[PATCH net-next v4 6/8] net: sched: create tc_can_offload_extack() wrapper

2018-01-19 Thread Jakub Kicinski
From: Quentin Monnet Create a wrapper around tc_can_offload() that takes an additional extack pointer argument in order to output an error message if TC offload is disabled on the device. In this way, the error message is handled by the core and can be the same for all drivers. Signed-off-by: Q