Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-04-09 Thread Toke Høiland-Jørgensen
Jesper Dangaard Brouer writes: > On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen > wrote: > >> +void dev_map_put_default_map(struct net *net) >> +{ >> +mutex_lock(&dev_map_mtx); > > Looks like a white-space error... > >> +if (atomic_dec_and_test(&net->xdp.default_map.use_c

Re: [PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-04-09 Thread Jesper Dangaard Brouer
On Mon, 08 Apr 2019 19:05:56 +0200 Toke Høiland-Jørgensen wrote: > +void dev_map_put_default_map(struct net *net) > +{ > +mutex_lock(&dev_map_mtx); Looks like a white-space error... > + if (atomic_dec_and_test(&net->xdp.default_map.use_cnt)) { > + __dev_map_release_defa

[PATCH net-next v4 4/6] xdp: Always use a devmap for XDP_REDIRECT to a device

2019-04-08 Thread Toke Høiland-Jørgensen
An XDP program can redirect packets between interfaces using either the xdp_redirect() helper or the xdp_redirect_map() helper. Apart from the flexibility of updating maps from userspace, the redirect_map() helper also uses the map structure to batch packets, which results in a significant (around