Re: [PATCH net-next v4 1/4] ethtool: provide customized dim profile management

2024-04-09 Thread Heng Qi
Will modify things as you sugguested. Thanks! 在 2024/4/9 上午3:13, Jakub Kicinski 写道: On Mon, 8 Apr 2024 11:44:27 +0800 Heng Qi wrote: + nla_for_each_nested(nest, nests, rem) { + if (WARN_ONCE(nla_type(nest) != ETHTOOL_A_MODERATIONS_MODERATION, +

Re: [PATCH net-next v4 1/4] ethtool: provide customized dim profile management

2024-04-08 Thread Jakub Kicinski
On Mon, 8 Apr 2024 11:44:27 +0800 Heng Qi wrote: > + nla_for_each_nested(nest, nests, rem) { > + if (WARN_ONCE(nla_type(nest) != > ETHTOOL_A_MODERATIONS_MODERATION, > + "unexpected nest attrtype %u\n", nla_type(nest))) Maybe just use the newly added nla_

Re: [PATCH net-next v4 1/4] ethtool: provide customized dim profile management

2024-04-08 Thread Jakub Kicinski
On Mon, 8 Apr 2024 11:44:27 +0800 Heng Qi wrote: > --- a/Documentation/netlink/specs/ethtool.yaml > +++ b/Documentation/netlink/specs/ethtool.yaml > @@ -408,6 +408,18 @@ attribute-sets: >- > name: combined-count > type: u32 > + - > + name: profile > + attributes

[PATCH net-next v4 1/4] ethtool: provide customized dim profile management

2024-04-07 Thread Heng Qi
The NetDIM library, currently leveraged by an array of NICs, delivers excellent acceleration benefits. Nevertheless, NICs vary significantly in their dim profile list prerequisites. Specifically, virtio-net backends may present diverse sw or hw device implementation, making a one-size-fits-all par