Re: [PATCH net-next v4 1/2] fix return of iptunnel_xmit

2015-10-09 Thread Debabrata Banerjee
Andreas, I think we need to use the net_xmit defines so the errors are masked properly, how about: - if (unlikely(net_xmit_eval(err))) - pkt_len = 0; - return pkt_len; + if (likely(net_xmit_eval(err) == 0)) + return pkt_len; + else +

Re: [PATCH net-next v4 1/2] fix return of iptunnel_xmit

2015-10-09 Thread Sergei Shtylyov
Hello. On 10/9/2015 12:27 PM, Andreas Schultz wrote: All users of iptunnel_xmit expect the return value to be the packet length on success (>0), negative for a tx error and zero for a tx dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the Didn't checkpatch.pl compalin about

[PATCH net-next v4 1/2] fix return of iptunnel_xmit

2015-10-09 Thread Andreas Schultz
All users of iptunnel_xmit expect the return value to be the packet length on success (>0), negative for a tx error and zero for a tx dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the negative return case was lost. This bug was introduced when the ip_tunnel_core code was refactor