Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Greg Kroah-Hartman
On Tue, Jan 17, 2017 at 03:21:47PM -0800, Florian Fainelli wrote: > Add a helper function to lookup a device reference given a class name. > This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and > make it more generic. > > Signed-off-by: Florian Fainelli > --- > drivers/base/co

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
On 01/17/2017 04:07 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 2:04 AM, Florian Fainelli > wrote: >> On 01/17/2017 04:00 PM, Andy Shevchenko wrote: >>> On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli >>> wrote: On 01/17/2017 03:34 PM, Andy Shevchenko wrote: > On Wed, Jan 18

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 2:04 AM, Florian Fainelli wrote: > On 01/17/2017 04:00 PM, Andy Shevchenko wrote: >> On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli >> wrote: >>> On 01/17/2017 03:34 PM, Andy Shevchenko wrote: On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli wrote: >> But

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
On 01/17/2017 04:00 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli > wrote: >> On 01/17/2017 03:34 PM, Andy Shevchenko wrote: >>> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli >>> wrote: > +static int device_class_name_match(struct device *dev, void *cl

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 1:43 AM, Florian Fainelli wrote: > On 01/17/2017 03:34 PM, Andy Shevchenko wrote: >> On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli >> wrote: >>> +static int device_class_name_match(struct device *dev, void *class) >> >> And why not const char *class? > > This was rai

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
On 01/17/2017 03:34 PM, Andy Shevchenko wrote: > On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli > wrote: >> Add a helper function to lookup a device reference given a class name. >> This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and >> make it more generic. > > >> +stati

Re: [PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Andy Shevchenko
On Wed, Jan 18, 2017 at 1:21 AM, Florian Fainelli wrote: > Add a helper function to lookup a device reference given a class name. > This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and > make it more generic. > +static int device_class_name_match(struct device *dev, void *clas

[PATCH net-next v4 05/10] drivers: base: Add device_find_in_class_name()

2017-01-17 Thread Florian Fainelli
Add a helper function to lookup a device reference given a class name. This is a preliminary patch to remove adhoc code from net/dsa/dsa.c and make it more generic. Signed-off-by: Florian Fainelli --- drivers/base/core.c| 31 +++ include/linux/device.h | 2 ++ 2