Re: [PATCH net-next v4 03/12] net: ethernet: aquantia: Fixes for aq_ndev_change_mtu

2017-02-20 Thread Lino Sanfilippo
Hi, On 20.02.2017 20:36, Pavel Belous wrote: > From: Pavel Belous > > 1)Removed unnecessary comparsion "old_mtu == new_mtu". > This check is not needed. Function aq_ndev_change_mtu wont be called > if mtu has not changed. > > 2)Removed extra assignment ndev->mtu = new_mtu; > This assignment alr

[PATCH net-next v4 03/12] net: ethernet: aquantia: Fixes for aq_ndev_change_mtu

2017-02-20 Thread Pavel Belous
From: Pavel Belous 1)Removed unnecessary comparsion "old_mtu == new_mtu". This check is not needed. Function aq_ndev_change_mtu wont be called if mtu has not changed. 2)Removed extra assignment ndev->mtu = new_mtu; This assignment already done inside __dev_set_mtu(). 3)Use core MTU checking for