Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-11 Thread Saeed Mahameed
On Thu, 2021-02-11 at 23:59 +0200, Ido Schimmel wrote: > On Wed, Feb 10, 2021 at 09:09:41PM -0800, Saeed Mahameed wrote: > > This won't solve anything other than compilation time dependency > > between built-in modules to external modules, this is not the case. > > > > our case is when both mlx5 a

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-11 Thread Ido Schimmel
On Wed, Feb 10, 2021 at 09:09:41PM -0800, Saeed Mahameed wrote: > This won't solve anything other than compilation time dependency > between built-in modules to external modules, this is not the case. > > our case is when both mlx5 and psample are modules, you can't load mlx5 > without loading psa

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-10 Thread Saeed Mahameed
On Tue, 2021-02-09 at 08:47 +0200, Leon Romanovsky wrote: > On Mon, Feb 08, 2021 at 07:07:35PM +0200, Ido Schimmel wrote: > > On Mon, Feb 08, 2021 at 11:07:02AM +0200, Leon Romanovsky wrote: > > > > [...] > > I don't know. What are they complaining about? That psample needs > > to be > > instal

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 12:01 PM Leon Romanovsky wrote: > > On Tue, Feb 09, 2021 at 11:25:33AM +0200, Or Gerlitz wrote: > > On Tue, Feb 9, 2021 at 8:49 AM Leon Romanovsky wrote: > > > > [..] > > > > > This is another problem with mlx5 - complete madness with config options > > > that are not possi

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-09 Thread Leon Romanovsky
On Tue, Feb 09, 2021 at 11:25:33AM +0200, Or Gerlitz wrote: > On Tue, Feb 9, 2021 at 8:49 AM Leon Romanovsky wrote: > > [..] > > > This is another problem with mlx5 - complete madness with config options > > that are not possible to test. > > ➜ kernel git:(rdma-next) grep -h "config MLX" > > dri

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-09 Thread Or Gerlitz
On Tue, Feb 9, 2021 at 8:49 AM Leon Romanovsky wrote: [..] > This is another problem with mlx5 - complete madness with config options > that are not possible to test. > ➜ kernel git:(rdma-next) grep -h "config MLX" > drivers/net/ethernet/mellanox/mlx5/core/Kconfig | awk '{ print $2}' | sort >

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 07:07:35PM +0200, Ido Schimmel wrote: > On Mon, Feb 08, 2021 at 11:07:02AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 08, 2021 at 10:57:46AM +0200, Ido Schimmel wrote: > > > On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote: > > > > On Mon, Feb 01, 2021 at 0

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-08 Thread Ido Schimmel
On Mon, Feb 08, 2021 at 11:07:02AM +0200, Leon Romanovsky wrote: > On Mon, Feb 08, 2021 at 10:57:46AM +0200, Ido Schimmel wrote: > > On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote: > > > On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote: > > > > On Mon, Feb 01, 2021 at 0

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 10:57:46AM +0200, Ido Schimmel wrote: > On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote: > > > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote: > > > > Hi Ido, > > > > > > > > On 1/30/

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-08 Thread Ido Schimmel
On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote: > On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote: > > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote: > > > Hi Ido, > > > > > > On 1/30/2021 10:42 PM, Ido Schimmel wrote: > > > > On Fri, Jan 29, 2021 at 12:30:0

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-07 Thread Leon Romanovsky
On Mon, Feb 01, 2021 at 08:08:37PM +0200, Ido Schimmel wrote: > On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote: > > Hi Ido, > > > > On 1/30/2021 10:42 PM, Ido Schimmel wrote: > > > On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: > > > > On Fri, 29 Jan 2021 14:08:39 +0800 C

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-01 Thread Ido Schimmel
On Mon, Feb 01, 2021 at 09:37:11AM +0800, Chris Mi wrote: > Hi Ido, > > On 1/30/2021 10:42 PM, Ido Schimmel wrote: > > On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: > > > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > > > Instead of discussing it several days, maybe it's

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-31 Thread Chris Mi
Hi Ido, On 1/30/2021 10:42 PM, Ido Schimmel wrote: On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: Instead of discussing it several days, maybe it's better to review current patch, so that we can move forward :) It took you 4

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-30 Thread Ido Schimmel
On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > Instead of discussing it several days, maybe it's better to review > > current patch, so that we can move forward :) > > It took you 4 revisions to post a patch which builds cl

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-30 Thread Chris Mi
On 1/30/2021 5:50 AM, Jakub Kicinski wrote: On Thu, 28 Jan 2021 09:45:43 +0800 Chris Mi wrote: In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is init

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-29 Thread Jakub Kicinski
On Thu, 28 Jan 2021 09:45:43 +0800 Chris Mi wrote: > In order to send sampled packets to userspace, NIC driver calls > psample api directly. But it creates a hard dependency on module > psample. Introduce psample_ops to remove the hard dependency. > It is initialized when psample module is loaded a

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 12:44:59 -0800 Saeed Mahameed wrote: > On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote: > > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > > Instead of discussing it several days, maybe it's better to review > > > current patch, so that we can move forward :)

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-29 Thread Saeed Mahameed
On Fri, 2021-01-29 at 12:30 -0800, Jakub Kicinski wrote: > On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > > Instead of discussing it several days, maybe it's better to review > > current patch, so that we can move forward :) > > It took you 4 revisions to post a patch which builds cleanly a

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-29 Thread Jakub Kicinski
On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: > Instead of discussing it several days, maybe it's better to review > current patch, so that we can move forward :) It took you 4 revisions to post a patch which builds cleanly and now you want to hasten the review? My favorite kind of submissio

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-28 Thread Chris Mi
On 1/29/2021 1:14 PM, Cong Wang wrote: On Wed, Jan 27, 2021 at 5:48 PM Chris Mi wrote: In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is initialized

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-28 Thread Cong Wang
On Wed, Jan 27, 2021 at 5:48 PM Chris Mi wrote: > > In order to send sampled packets to userspace, NIC driver calls > psample api directly. But it creates a hard dependency on module > psample. Introduce psample_ops to remove the hard dependency. > It is initialized when psample module is loaded a

[PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-27 Thread Chris Mi
In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is initialized when psample module is loaded and set to NULL when the module is unloaded. Reported-by: k