Re: [PATCH net-next v4] mpls: support for dead routes

2015-11-24 Thread Robert Shearman
On 24/11/15 03:41, roopa wrote: On 11/23/15, 6:15 AM, Robert Shearman wrote: On 21/11/15 05:16, Roopa Prabhu wrote: +if (!rt_new) { +pr_warn("mpls_ifdown: kmemdup failed\n"); It isn't safe to leave the current route untouched if the net device is being deleted, since a ne

Re: [PATCH net-next v4] mpls: support for dead routes

2015-11-23 Thread roopa
On 11/23/15, 6:15 AM, Robert Shearman wrote: > On 21/11/15 05:16, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls >> routes due to link events. Also adds code to ignore dead >> routes during route selection. >> >> Unlike ip routes, mpl

Re: [PATCH net-next v4] mpls: support for dead routes

2015-11-23 Thread Robert Shearman
On 21/11/15 05:16, Roopa Prabhu wrote: From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is curre

[PATCH net-next v4] mpls: support for dead routes

2015-11-20 Thread Roopa Prabhu
From: Roopa Prabhu Adds support for RTNH_F_DEAD and RTNH_F_LINKDOWN flags on mpls routes due to link events. Also adds code to ignore dead routes during route selection. Unlike ip routes, mpls routes are not deleted when the route goes dead. This is current mpls behaviour and this patch does not