Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-29 Thread Robert Shearman
On 29/07/15 11:51, Thomas Graf wrote: On 07/29/15 at 11:38am, Robert Shearman wrote: On 28/07/15 17:16, roopa wrote: RTA_OIF is optional for ipv4 and ipv6 routes and we wanted to keep it that way for mpls routes as well (Quagga is the application in our use case). It was a simple patch...until

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-29 Thread Thomas Graf
On 07/29/15 at 11:38am, Robert Shearman wrote: > On 28/07/15 17:16, roopa wrote: > >RTA_OIF is optional for ipv4 and ipv6 routes and we wanted to keep it > >that way for mpls routes as well (Quagga is the application in our use > >case). > >It was a simple patch...until i realized the IPV6 dependen

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-29 Thread Robert Shearman
On 28/07/15 17:16, roopa wrote: On 7/28/15, 7:17 AM, Robert Shearman wrote: On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOK

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 3:22 PM, Hannes Frederic Sowa wrote: Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: ipv6_stub_impl.ipv6_dst_lookup seems to require sk today. But it only needs it to get 'net' in the beginning and sk is optional afterwards. I will submit a patch to add 'net' as an arg to

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Hannes Frederic Sowa
Hi roopa, On Tue, Jul 28, 2015, at 21:28, roopa wrote: > On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: > > Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do > > that and don't have a run-time dependency on IPv6 at all (for the cost > > of a function pointer). > ipv6_stub_

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do that and don't have a run-time dependency on IPv6 at all (for the cost of a function pointer). ipv6_stub_impl.ipv6_dst_lookup seems to require sk today. But it only needs it t

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 7:17 AM, Robert Shearman wrote: On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if us

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread roopa
On 7/28/15, 6:04 AM, Hannes Frederic Sowa wrote: On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Robert Shearman
On 28/07/15 07:40, Roopa Prabhu wrote: From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute.

Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-28 Thread Hannes Frederic Sowa
On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote: > From: Roopa Prabhu > > Undefined reference to ip6_route_output and ip_route_output > was reported with CONFIG_INET=n and CONFIG_IPV6=n. > > This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP > to lookup nexthop device if user has not specif

[PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

2015-07-27 Thread Roopa Prabhu
From: Roopa Prabhu Undefined reference to ip6_route_output and ip_route_output was reported with CONFIG_INET=n and CONFIG_IPV6=n. This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP to lookup nexthop device if user has not specified it in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP depen