Re: [PATCH net-next v3 8/8] virtio-net: free old xmit handle xsk

2021-04-07 Thread Jason Wang
在 2021/4/7 下午5:26, Xuan Zhuo 写道: + __free_old_xmit(sq, false, &stats); Let's use a separate patch for this kind of factoring. It is also possible to encounter xsk here, so it should not be a separate patch. Thanks. You can do the factoring first and add xsk stuffs on top. Thanks

Re: [PATCH net-next v3 8/8] virtio-net: free old xmit handle xsk

2021-04-06 Thread Jason Wang
在 2021/3/31 下午3:11, Xuan Zhuo 写道: Based on the last two bit of ptr returned by virtqueue_get_buf, 01 represents the packet sent by xdp, 10 is the packet sent by xsk, and 00 is skb by default. If the xmit work of xsk has not been completed, but the ring is full, napi must first exit and wait fo

Re: [PATCH net-next v3 8/8] virtio-net: free old xmit handle xsk

2021-03-31 Thread kernel test robot
Hi Xuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Xuan-Zhuo/virtio-net-support-xdp-socket-zero-copy-xmit/20210331-151437 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-

[PATCH net-next v3 8/8] virtio-net: free old xmit handle xsk

2021-03-31 Thread Xuan Zhuo
Based on the last two bit of ptr returned by virtqueue_get_buf, 01 represents the packet sent by xdp, 10 is the packet sent by xsk, and 00 is skb by default. If the xmit work of xsk has not been completed, but the ring is full, napi must first exit and wait for the ring to be available, so need_wa