Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info

2019-02-01 Thread Jiri Pirko
Thu, Jan 31, 2019 at 06:29:25PM CET, jakub.kicin...@netronome.com wrote: >On Thu, 31 Jan 2019 09:25:08 -0800, Jakub Kicinski wrote: >> On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote: >> > From: kbuild test robot >> > Date: Fri, 1 Feb 2019 00:19:33 +0800 >> > >> > > All errors (new

Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info

2019-01-31 Thread Jakub Kicinski
On Thu, 31 Jan 2019 09:25:08 -0800, Jakub Kicinski wrote: > On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote: > > From: kbuild test robot > > Date: Fri, 1 Feb 2019 00:19:33 +0800 > > > > > All errors (new ones prefixed by >>): > > > > > >m68k-linux-gnu-ld: drivers/rtc/proc.o: i

Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info

2019-01-31 Thread Jakub Kicinski
On Thu, 31 Jan 2019 09:23:03 -0800 (PST), David Miller wrote: > From: kbuild test robot > Date: Fri, 1 Feb 2019 00:19:33 +0800 > > > All errors (new ones prefixed by >>): > > > >m68k-linux-gnu-ld: drivers/rtc/proc.o: in function > > `is_rtc_hctosys.isra.0': > >proc.c:(.text+0x178): unde

Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info

2019-01-31 Thread David Miller
From: kbuild test robot Date: Fri, 1 Feb 2019 00:19:33 +0800 > All errors (new ones prefixed by >>): > >m68k-linux-gnu-ld: drivers/rtc/proc.o: in function `is_rtc_hctosys.isra.0': >proc.c:(.text+0x178): undefined reference to `strcmp' >m68k-linux-gnu-ld: net/core/ethtool.o: in functi

Re: [PATCH net-next v3 8/8] ethtool: add compat for devlink info

2019-01-31 Thread kbuild test robot
Hi Jakub, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Jakub-Kicinski/devlink-add-device-driver-information-API/20190131-224626 config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gnu-

[PATCH net-next v3 8/8] ethtool: add compat for devlink info

2019-01-30 Thread Jakub Kicinski
If driver did not fill the fw_version field, try to call into the new devlink get_info op and collect the versions that way. We assume ethtool was always reporting running versions. v3 (Jiri): - do a dump and then parse it instead of special handling; - concatenate all versions (well, all that f