Re: [PATCH net-next v3 6/9] net: phy: icplus: don't set APS_EN bit on IP101G

2021-02-10 Thread Andrew Lunn
On Wed, Feb 10, 2021 at 10:08:06PM +0100, Michael Walle wrote: > This bit is reserved as 'always-write-1'. While this is not a particular > error, because we are only setting it, guard it by checking the model to > prevent errors in the future. > > Signed-off-by: Michael Walle Reviewed-by: Andre

[PATCH net-next v3 6/9] net: phy: icplus: don't set APS_EN bit on IP101G

2021-02-10 Thread Michael Walle
This bit is reserved as 'always-write-1'. While this is not a particular error, because we are only setting it, guard it by checking the model to prevent errors in the future. Signed-off-by: Michael Walle --- Changes since v2: - none Changes since v1: - dropped the model check. Instead use two