Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 01:51:55PM +, Ioana Ciornei wrote: > > Right, but we're talking about hardware that is common not only in DSA but > > elsewhere - and we already deal with that outside of DSA with PHYs. > > I said before why the PHY use case is different from a PCS tightly > coupled ins

RE: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Ioana Ciornei
> Subject: Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops > > On Mon, Jun 22, 2020 at 12:35:06PM +, Ioana Ciornei wrote: > > > > > Subject: Re: [PATCH net-next v3 5/9] net: dsa: add support for > > > phylink_pcs_ops > > > >

Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 12:35:06PM +, Ioana Ciornei wrote: > > > Subject: Re: [PATCH net-next v3 5/9] net: dsa: add support for > > phylink_pcs_ops > > > > On Mon, Jun 22, 2020 at 12:10:57PM +0100, Russell King - ARM Linux admin > > wrote: > > >

RE: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Ioana Ciornei
> Subject: Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops > > On Mon, Jun 22, 2020 at 12:10:57PM +0100, Russell King - ARM Linux admin > wrote: > > On Mon, Jun 22, 2020 at 11:22:13AM +0100, Russell King - ARM Linux admin > wrote: > > > On M

Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 12:10:57PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Jun 22, 2020 at 11:22:13AM +0100, Russell King - ARM Linux admin > wrote: > > On Mon, Jun 22, 2020 at 01:54:47AM +0300, Ioana Ciornei wrote: > > > In order to support split PCS using PHYLINK properly, we need

Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 11:22:13AM +0100, Russell King - ARM Linux admin wrote: > On Mon, Jun 22, 2020 at 01:54:47AM +0300, Ioana Ciornei wrote: > > In order to support split PCS using PHYLINK properly, we need to add a > > phylink_pcs_ops structure. > > > > Note that a DSA driver that wants to us

Re: [PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-22 Thread Russell King - ARM Linux admin
On Mon, Jun 22, 2020 at 01:54:47AM +0300, Ioana Ciornei wrote: > In order to support split PCS using PHYLINK properly, we need to add a > phylink_pcs_ops structure. > > Note that a DSA driver that wants to use these needs to implement all 4 > of them: the DSA core checks the presence of these 4 fu

[PATCH net-next v3 5/9] net: dsa: add support for phylink_pcs_ops

2020-06-21 Thread Ioana Ciornei
In order to support split PCS using PHYLINK properly, we need to add a phylink_pcs_ops structure. Note that a DSA driver that wants to use these needs to implement all 4 of them: the DSA core checks the presence of these 4 function pointers in dsa_switch_ops and only then does it add a PCS to PHYL