RE: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-16 Thread Dan Jurgens
> From: Jakub Kicinski > Sent: Tuesday, April 16, 2024 9:27 AM > To: Dan Jurgens > On Tue, 16 Apr 2024 03:15:34 + Dan Jurgens wrote: > > Which version? It compiles for me with: > > $ clang -v > > clang version 15.0.7 (Fedora 15.0.7-2.fc37) > > clang version 17.0.6 (Fedora 17.0.6-2.fc39) >

Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-16 Thread Jakub Kicinski
On Tue, 16 Apr 2024 03:15:34 + Dan Jurgens wrote: > Which version? It compiles for me with: > $ clang -v > clang version 15.0.7 (Fedora 15.0.7-2.fc37) clang version 17.0.6 (Fedora 17.0.6-2.fc39) allmodconfig The combination of UNIQUE() goto and guard seems to make it unhappy: ../drivers/net

RE: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-15 Thread Dan Jurgens
> Pirko > Subject: Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX > coalesce > > On Fri, 12 Apr 2024 14:53:08 -0500 Daniel Jurgens wrote: > > Once the RTNL locking around the control buffer is removed there can > > be contention on the per queue RX i

RE: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-15 Thread Dan Jurgens
at.com; Jiri Pirko > > Subject: Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX > coalesce > > > > 在 2024/4/13 上午3:53, Daniel Jurgens 写道: > > Once the RTNL locking around the control buffer is removed there can > > be contention on the per queu

Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-15 Thread Heng Qi
在 2024/4/13 上午3:53, Daniel Jurgens 写道: Once the RTNL locking around the control buffer is removed there can be contention on the per queue RX interrupt coalescing data. Use a spin lock per queue. Signed-off-by: Daniel Jurgens --- drivers/net/virtio_net.c | 23 --- 1 fi

Re: [PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-12 Thread Jakub Kicinski
On Fri, 12 Apr 2024 14:53:08 -0500 Daniel Jurgens wrote: > Once the RTNL locking around the control buffer is removed there can be > contention on the per queue RX interrupt coalescing data. Use a spin > lock per queue. Does not compile on Clang. > + scoped_guard(spinlock, &vi

[PATCH net-next v3 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-12 Thread Daniel Jurgens
Once the RTNL locking around the control buffer is removed there can be contention on the per queue RX interrupt coalescing data. Use a spin lock per queue. Signed-off-by: Daniel Jurgens --- drivers/net/virtio_net.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-)