Re: [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-18 Thread Jakub Kicinski
On Wed, 18 Nov 2020 16:43:33 -0500 Willem de Bruijn wrote: > On Tue, Nov 17, 2020 at 12:19 PM Jakub Kicinski wrote: > > Sorry I misremembered it's 4. We can leave that as is. > > Instead of having to remember, maybe we should have a file in > tools/testing/selftest to define constants? > > I d

Re: [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-18 Thread Willem de Bruijn
On Tue, Nov 17, 2020 at 12:19 PM Jakub Kicinski wrote: > > On Tue, 17 Nov 2020 12:32:36 +0100 Antonio Cardace wrote: > > On Mon, Nov 16, 2020 at 04:45:03PM -0800, Jakub Kicinski wrote: > > > On Sat, 14 Nov 2020 00:16:55 +0100 Antonio Cardace wrote: > > > > Add scripts to test ring and coalesce set

Re: [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 12:32:36 +0100 Antonio Cardace wrote: > On Mon, Nov 16, 2020 at 04:45:03PM -0800, Jakub Kicinski wrote: > > On Sat, 14 Nov 2020 00:16:55 +0100 Antonio Cardace wrote: > > > Add scripts to test ring and coalesce settings > > > of netdevsim. > > > > > > Signed-off-by: Antonio Ca

Re: [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-17 Thread Antonio Cardace
On Mon, Nov 16, 2020 at 04:45:03PM -0800, Jakub Kicinski wrote: > On Sat, 14 Nov 2020 00:16:55 +0100 Antonio Cardace wrote: > > Add scripts to test ring and coalesce settings > > of netdevsim. > > > > Signed-off-by: Antonio Cardace > > > @@ -0,0 +1,68 @@ > > +#!/bin/bash > > +# SPDX-License-Iden

Re: [PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-16 Thread Jakub Kicinski
On Sat, 14 Nov 2020 00:16:55 +0100 Antonio Cardace wrote: > Add scripts to test ring and coalesce settings > of netdevsim. > > Signed-off-by: Antonio Cardace > @@ -0,0 +1,68 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0-only > + > +source ethtool-common.sh > + > +function get_value { >

[PATCH net-next v3 4/4] selftests: add ring and coalesce selftests

2020-11-13 Thread Antonio Cardace
Add scripts to test ring and coalesce settings of netdevsim. Signed-off-by: Antonio Cardace --- .../drivers/net/netdevsim/ethtool-coalesce.sh | 68 +++ .../drivers/net/netdevsim/ethtool-ring.sh | 53 +++ 2 files changed, 121 insertions(+) create mode 100755 tool