Re: [PATCH net-next v3 4/4] gve: Add support for raw addressing in the tx path

2020-10-02 Thread kernel test robot
Hi David, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/David-Awogbemila/GVE-Raw-Addressing/20200924-091514 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 68d4fd30c83b1b

Re: [PATCH net-next v3 4/4] gve: Add support for raw addressing in the tx path

2020-09-30 Thread Jakub Kicinski
On Wed, 30 Sep 2020 09:09:57 -0700 David Awogbemila wrote: > > > + len -= hlen; > > > + addr += hlen; > > > + seg_desc = &tx->desc[(tx->req + 1) & tx->mask]; > > > + seg_idx_bias = 2; > > > + gve_tx_fill_seg_desc(seg_desc, skb, is_gso, len

Re: [PATCH net-next v3 4/4] gve: Add support for raw addressing in the tx path

2020-09-24 Thread Jakub Kicinski
On Wed, 23 Sep 2020 18:01:04 -0700 David Awogbemila wrote: > + info->skb = skb; double space > + addr = dma_map_single(tx->dev, skb->data, len, DMA_TO_DEVICE); > + if (unlikely(dma_mapping_error(tx->dev, addr))) { > + priv->dma_mapping_error++; > + goto drop;