Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support

2020-08-18 Thread Andrew Lunn
> @@ -553,32 +554,21 @@ static int smsc95xx_phy_update_flowcontrol(struct > usbnet *dev, u8 duplex, > static int smsc95xx_link_reset(struct usbnet *dev) > { > struct smsc95xx_priv *pdata = dev->driver_priv; > - struct mii_if_info *mii = &dev->mii; > - struct ethtool_cmd ecmd = { .c

Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support

2020-08-18 Thread Andrew Lunn
On Tue, Aug 18, 2020 at 01:11:27PM +0200, Andre Edich wrote: > Generally, each PHY has their own configuration and it can be done > through an external PHY driver. The smsc95xx driver uses only the > hard-coded internal PHY configuration. > > This patch adds phylib support to probe external PHY d

Re: [PATCH net-next v3 3/3] smsc95xx: add phylib support

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 13:11:27 +0200 Andre Edich wrote: > +static inline int lan87xx_config_aneg(struct phy_device *phydev) > +static inline int lan87xx_config_aneg_ext(struct phy_device *phydev) Please don't use static inline in C files, the compiler will know what to inline so it's unnecessary, a

[PATCH net-next v3 3/3] smsc95xx: add phylib support

2020-08-18 Thread Andre Edich
Generally, each PHY has their own configuration and it can be done through an external PHY driver. The smsc95xx driver uses only the hard-coded internal PHY configuration. This patch adds phylib support to probe external PHY drivers for configuring external PHYs. The MDI-X configuration for the