Re: [PATCH net-next v3 2/4] sch_htb: Hierarchical QoS hardware offload

2021-01-04 Thread Maxim Mikityanskiy
On 2020-12-22 03:17, Jakub Kicinski wrote: On Tue, 15 Dec 2020 09:42:11 +0200 Maxim Mikityanskiy wrote: + q->offload = nla_get_flag(tb[TCA_HTB_OFFLOAD]); + + if (q->offload) { + if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) + return -

Re: [PATCH net-next v3 2/4] sch_htb: Hierarchical QoS hardware offload

2020-12-21 Thread Jakub Kicinski
On Tue, 15 Dec 2020 09:42:11 +0200 Maxim Mikityanskiy wrote: > + q->offload = nla_get_flag(tb[TCA_HTB_OFFLOAD]); > + > + if (q->offload) { > + if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) > + return -EOPNOTSUPP; Is there a check somewhere maki

[PATCH net-next v3 2/4] sch_htb: Hierarchical QoS hardware offload

2020-12-14 Thread Maxim Mikityanskiy
HTB doesn't scale well because of contention on a single lock, and it also consumes CPU. This patch adds support for offloading HTB to hardware that supports hierarchical rate limiting. This solution addresses two main problems of scaling HTB: 1. Contention by flow classification. Currently the f